Match autofill fields look with Style applied#3040
Match autofill fields look with Style applied#3040AbdiTolesa wants to merge 2 commits intomasterfrom
Conversation
📝 WalkthroughWalkthroughAdds CSS rules in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| PHP | Mar 24, 2026 11:08a.m. | Review ↗ | |
| JavaScript | Mar 24, 2026 11:08a.m. | Review ↗ |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
css/custom_theme.css.php (1)
231-233: Consider adding text color override for complete autofill styling.The box-shadow technique correctly handles the background color override. However, browsers may also change the text color when autofilling. For complete styling consistency, consider adding
-webkit-text-fill-color:♻️ Suggested enhancement
.with_frm_style input:-webkit-autofill { -webkit-box-shadow: 0 0 0 30px var(--bg-color) inset <?php echo esc_html( $important ); ?>; + -webkit-text-fill-color: var(--text-color) <?php echo esc_html( $important ); ?>; }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@css/custom_theme.css.php` around lines 231 - 233, Add a text color override to the autofill rule so browser autofill doesn't change input text color: update the .with_frm_style input:-webkit-autofill style handler to set -webkit-text-fill-color to the intended foreground (e.g., var(--text-color) or the same variable used for normal inputs) alongside the existing -webkit-box-shadow rule to ensure both background and text use your theme colors.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@css/custom_theme.css.php`:
- Around line 231-233: Add a text color override to the autofill rule so browser
autofill doesn't change input text color: update the .with_frm_style
input:-webkit-autofill style handler to set -webkit-text-fill-color to the
intended foreground (e.g., var(--text-color) or the same variable used for
normal inputs) alongside the existing -webkit-box-shadow rule to ensure both
background and text use your theme colors.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 42aedc05-d734-41c8-a393-c0bc16b328d1
📒 Files selected for processing (1)
css/custom_theme.css.php
Fix https://github.com/Strategy11/formidable-pro/issues/6393
Test steps
Before:
CleanShot.2026-03-24.at.14.09.29.mp4
After:
CleanShot.2026-03-24.at.14.08.11.mp4
Summary by CodeRabbit