Skip to content

Fix Conditional Logic not copied over when duplicating a field #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbdiTolesa wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix Conditional Logic not copied over when duplicating a field #2945

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8117f54
Fix Conditional Logic not copied over when duplicating a field
AbdiTolesa Feb 6, 2026
5aea1b7
Extract related code to a new function
AbdiTolesa Feb 6, 2026
dd5d54d
Fix code style errors
AbdiTolesa Feb 6, 2026
4c831a6
Fix code style errors
AbdiTolesa Feb 6, 2026
1cef77e
Change function name
AbdiTolesa Feb 24, 2026
5413ba6
Cast function return to integer to align it with the function doc
AbdiTolesa Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion classes/controllers/FrmFieldsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ public static function load_single_field( $field_object, $values, $form_id = 0 )
}

if ( ! isset( $field ) && is_object( $field_object ) ) {
$field_object->parent_form_id = $values['id'] ?? $field_object->form_id;
$field_object->parent_form_id = self::get_form_id_from_field_or_form( $field_object, $values );
$field = FrmFieldsHelper::setup_edit_vars( $field_object );
}

Expand All @@ -205,6 +205,28 @@ public static function load_single_field( $field_object, $values, $form_id = 0 )
require FrmAppHelper::plugin_path() . '/classes/views/frm-forms/add_field.php';
}

/**
* Get the parent form id for the field.
*
* @since x.x
*
* @param object $field_object The field object.
* @param array $values Either form or field values.
*
* @return int
*/
private static function get_form_id_from_field_or_form( $field_object, $values ) {
$form_id = absint( $field_object->form_id );

if ( isset( $values['form_key'] ) ) {
return $values['id'] ?? $form_id;
}
Comment on lines +221 to +223
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

?? doesn't guard against $values['id'] === 0.

The DB-query path on line 227 deliberately uses a ternary to catch falsy results (including '0' from the DB). Line 222 uses ??, which only falls back on null / unset — so a $values['id'] of 0 (e.g. when the AJAX request carries no valid form ID) is returned as-is instead of falling back to $form_id.

🛡️ Proposed fix 
-		return $values['id'] ?? $form_id;
+		return ( $values['id'] ?? 0 ) ?: $form_id;
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
if ( isset( $values['form_key'] ) ) {
return $values['id'] ?? $form_id;
}
if ( isset( $values['form_key'] ) ) {
return ( $values['id'] ?? 0 ) ?: $form_id;
}
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@classes/controllers/FrmFieldsController.php` around lines 221 - 223, In
FrmFieldsController replace the null-coalescing return that uses $values['id']
?? $form_id with a falsy-checking fallback so a value of '0' or 0 falls back to
$form_id; specifically change the return in the block that checks
isset($values['form_key']) (the line returning $values['id'] ?? $form_id) to use
a ternary or equivalent falsy check (e.g. return $values['id'] ? $values['id'] :
$form_id) so it matches the DB-query path behavior.


$parent_form_id = absint( FrmDb::get_var( 'frm_forms', array( 'id' => $form_id ), 'parent_form_id' ) );

return $parent_form_id ? $parent_form_id : $form_id;
}

/**
* @since 3.0
*
Expand Down