-
Notifications
You must be signed in to change notification settings - Fork 19
Updated information about Clustered Lighting on Wiki #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JJL772
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Page content needs some work. The screenshots you provided a pretty great though!
Updated the requested phrases, fixed minor spelling mistakes and compressed 2 images.
|
@JJL772 done |
me when I accidentally tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have used a lot of images, like a lot. You shouldn't that many IMO and just instruct the user correctly where they need to go. The screenshots showing the flags menu with the effect it has in the game is a nice thing, though instead of having two separate images, basically condensing and reducing the amount of images used should be your goal.
Other than that, there are formatting fixes needed and few other bits so just look at the reviews.
|
@OrsellGit I don't mind the images. For tutorial-like stuff I prefer it actually. We do need a page with comprehensive technical documentation though. In the future, I intend to work on some of that. |
Updated styling, removed 6 images, reverted changes made to `test\_meta.json`.
OrsellGit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good! Good job!
Dealt with review for Laveig for JJ, nothing too big changed from last review besides the requested changes.
Clustered Lighting info hasn't been updated since the pages were initially added. This update completely rewrites them and adds an additional page about Clustered Light Inspector. Images have been updated as well.
Changes:
light_type_reference.mdanddifferences.md