Skip to content

Conversation

@Laveig
Copy link
Contributor

@Laveig Laveig commented Jan 18, 2026

Clustered Lighting info hasn't been updated since the pages were initially added. This update completely rewrites them and adds an additional page about Clustered Light Inspector. Images have been updated as well.

Changes:

  • Removed light_type_reference.md and differences.md
  • Added a page describing Clustered Light Inspector
  • Replaced most of the images with more clear and informative ones
  • Added more notes, tips and warnings about found features and bugs
  • Minor tweaks

Laveig added 2 commits January 19, 2026 00:04
old description is gone wth
JJL772
JJL772 previously requested changes Jan 18, 2026
Copy link
Member

@JJL772 JJL772 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page content needs some work. The screenshots you provided a pretty great though!

Updated the requested phrases, fixed minor spelling mistakes and compressed 2 images.
@Laveig
Copy link
Contributor Author

Laveig commented Jan 18, 2026

@JJL772 done

me when I accidentally tab
Copy link
Contributor

@OrsellGit OrsellGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have used a lot of images, like a lot. You shouldn't that many IMO and just instruct the user correctly where they need to go. The screenshots showing the flags menu with the effect it has in the game is a nice thing, though instead of having two separate images, basically condensing and reducing the amount of images used should be your goal.

Other than that, there are formatting fixes needed and few other bits so just look at the reviews.

@JJL772
Copy link
Member

JJL772 commented Jan 19, 2026

@OrsellGit I don't mind the images. For tutorial-like stuff I prefer it actually.

We do need a page with comprehensive technical documentation though. In the future, I intend to work on some of that.

Laveig and others added 2 commits January 19, 2026 14:04
Updated styling, removed 6 images, reverted changes made to `test\_meta.json`.
Copy link
Contributor

@OrsellGit OrsellGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! Good job!

@OrsellGit OrsellGit dismissed JJL772’s stale review January 19, 2026 20:31

Dealt with review for Laveig for JJ, nothing too big changed from last review besides the requested changes.

@OrsellGit OrsellGit merged commit 1893a90 into StrataSource:main Jan 19, 2026
@Laveig Laveig deleted the upd/laveig branch January 19, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants