Skip to content

Add check for Symmetric Key Encryption Algorithm #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bwiggin10 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add check for Symmetric Key Encryption Algorithm #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 40 additions & 3 deletions sp_CheckSecurity.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,15 +179,16 @@ DECLARE
, @ComputerNamePhysicalNetBIOS NVARCHAR(128)
, @ServerZeroName SYSNAME
, @InstanceName NVARCHAR(128)
, @Edition NVARCHAR(128);
, @Edition NVARCHAR(128)
, @DatabaseName NVARCHAR(128);

IF OBJECT_ID('tempdb..#Results') IS NOT NULL
DROP TABLE #Results;

CREATE TABLE #Results (
VulnerabilityLevel TINYINT
, Vulnerability VARCHAR(50)
, Issue VARCHAR(50)
, Issue VARCHAR(100)
, DatabaseName NVARCHAR(255)
, Details NVARCHAR(4000)
, ActionStep NVARCHAR(1000)
Expand Down Expand Up @@ -674,6 +675,42 @@ INNER JOIN sys.dm_database_encryption_keys d
ON c.thumbprint = d.encryptor_thumbprint;


/* check Symmetric Key encryption algorithm */
DECLARE db_cursor CURSOR FOR
SELECT name
FROM sys.databases
WHERE state_desc = 'ONLINE' AND database_id <> 2;

OPEN db_cursor;
FETCH NEXT FROM db_cursor INTO @DatabaseName;

WHILE @@FETCH_STATUS = 0
BEGIN
SET @SQL = N'
USE [' + @DatabaseName + '];

INSERT INTO #Results
SELECT DISTINCT
3
, ''Potential - review recommended''
, ''Symmetric Key uses legacy encryption algorithm''
, DB_NAME()
, ''The Symmetric Key ['' + name + ''] used for encryption in '' + DB_NAME() + '' uses the encryption algorithm '' + algorithm_desc COLLATE Latin1_General_CI_AS_KS_WS + ''.''
, ''The Symmetric Key should be recreated to use the more secure AES_256 algorithm (Note that this requires migrating encrypted data from the old key to a new one, the encryption algorithm of an existing key is not modifiable).''
, ''https://learn.microsoft.com/en-us/sql/t-sql/statements/alter-symmetric-key-transact-sql?view=sql-server-ver16''
FROM sys.symmetric_keys
WHERE algorithm_desc <> ''AES_256''
AND symmetric_key_id NOT IN (101, 102);
';
EXEC sp_executesql @SQL;

FETCH NEXT FROM db_cursor INTO @DatabaseName;
END

CLOSE db_cursor;
DEALLOCATE db_cursor;


/* check for database backup certificate backup */
IF @SQLVersionMajor >= 12 BEGIN
SET @SQL = '
Expand Down Expand Up @@ -1162,4 +1199,4 @@ IF @ShowHighOnly = 0
, ReadMoreURL
FROM #Results
ORDER BY 1, 2, 3, 4, 5