Fix DynamicSerilog registration conflict when using AddSteeltoe#1660
Closed
Fix DynamicSerilog registration conflict when using AddSteeltoe#1660
Conversation
When both DynamicSerilog and Management.Endpoint assemblies are loaded, BootstrapScanner's WireAllActuators and WireDistributedTracingLogProcessor internally call AddDynamicConsole, which can register before the user's AddDynamicSerilog due to IHostBuilder callback ordering. This causes AddDynamicSerilog to throw because it finds an existing IDynamicLoggerProvider. Fix by pre-registering DynamicSerilog within the same deferred callback as the actuator/tracing registration when the Serilog assembly is loaded. This ensures Serilog's IDynamicLoggerProvider is always present before AddDynamicConsole runs, which then gracefully skips. Made-with: Cursor
TimHess
changed the title
|
bart-vmware
reviewed
Mar 13, 2026
| [InlineData(HostBuilderType.WebHost)] | ||
| [InlineData(HostBuilderType.WebApplication)] | ||
| [InlineData(HostBuilderType.HostApplication)] | ||
| public async Task DynamicSerilog_WinsOverActuatorFallback(HostBuilderType hostBuilderType) |
Member
There was a problem hiding this comment.
This test doesn't seem to cover the reported problem. It succeeds even without the code changes.
Member
Author
|
Not only does the test not cover the reported problem, I can't actually reproduce it in the first place... I missed in the Cursor conversation that it made an assumption the bug was already confirmed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When both DynamicSerilog and Management.Endpoint assemblies are loaded, BootstrapScanner's WireAllActuators and WireDistributedTracingLogProcessor internally call AddDynamicConsole, which can register before the user's AddDynamicSerilog due to IHostBuilder callback ordering. This causes AddDynamicSerilog to throw because it finds an existing IDynamicLoggerProvider.
Fix by pre-registering DynamicSerilog within the same deferred callback as the actuator/tracing registration when the Serilog assembly is loaded. This ensures Serilog's IDynamicLoggerProvider is always present before AddDynamicConsole runs, which then gracefully skips.
Fixes #1658
Quality checklist
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.