Skip to content

Develop#59

Merged
trikunai merged 9 commits into
mainfrom
develop
May 18, 2026
Merged

Develop#59
trikunai merged 9 commits into
mainfrom
develop

Conversation

@trikunai
Copy link
Copy Markdown
Member

No description provided.

@trikunai trikunai requested review from Josepdal, PedroCM96 and iicc1 May 15, 2026 15:43
@trikunai trikunai self-assigned this May 15, 2026
run: |
set -euo pipefail
if [ "$BRANCH_NAME" = "main" ]; then
STAKING_API_URL="${PRO_STAKING_API_URL:-}"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Missing required deployment configuration can produce a broken image

Using ${PRO_STAKING_API_URL:-} (and the same fallback pattern for the other required build args) converts absent secrets/vars into empty strings, so set -u will not fail. The workflow can still build, push, and deploy an image with missing API/app URLs; add an explicit validation step that fails before docker build when any required value is empty.

@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot Bot commented May 15, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • .github/workflows/build-push-commit.yaml

Change Summary

  • Adds explicit validation for required Docker build configuration before building and pushing the image.
  • Removes empty-string fallback expansion for branch-specific deployment variables so missing configuration is no longer silently accepted.
  • Resolves the previous workflow issue where unset secrets/vars could produce a broken image.

Reviewed by gpt-5.5-2026-04-23 · 242,341 tokens

@trikunai trikunai merged commit 33468b4 into main May 18, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants