Skip to content

Conversation

@giamir
Copy link
Contributor

@giamir giamir commented Jan 27, 2026

SPARK-155

This PR:

  • Documents and showcase downvoting as an option for horizontal layouts in stacks docs
  • Adds an upvoteOnly boolean in the stacks svelte vote component that allow consumers to render vote components with only the upvote button. By default now for both vertical and horizontal layout, downvoting and upvoting buttons are shown
  • Update visual and a11y tests for vote component

How to test

  • Go to vote page in the stacks docs and check the markup and example to upvote/downvote in horizontal layout
  • Go to the vote component in storybook and check out the new upvote only story

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2026

🦋 Changeset detected

Latest commit: 1c7ba02

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@giamir giamir marked this pull request as draft January 27, 2026 14:49
@netlify
Copy link

netlify bot commented Jan 27, 2026

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit 1c7ba02
🔍 Latest deploy log https://app.netlify.com/projects/stacks/deploys/6978e22b00daec000815c1fc
😎 Deploy Preview https://deploy-preview-2148--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 27, 2026

Deploy Preview for stacks-svelte ready!

Name Link
🔨 Latest commit 1c7ba02
🔍 Latest deploy log https://app.netlify.com/projects/stacks-svelte/deploys/6978e22ae56827000819dd3a
😎 Deploy Preview https://deploy-preview-2148--stacks-svelte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@giamir giamir marked this pull request as ready for review January 27, 2026 16:05
Copy link
Collaborator

@mukunku mukunku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only thing that caught my eye was that there seems to be a large gap between the arrow and the number for the vertical upvote only component, but maybe that's intentional:

Image

@giamir
Copy link
Contributor Author

giamir commented Jan 27, 2026

The only thing that caught my eye was that there seems to be a large gap between the arrow and the number for the vertical upvote only component, but maybe that's intentional

Good point, I am actually unsure if we should officially support that variant.
The API allows for that combination but maybe it is not something we will see in the design.

@CGuindon
Copy link
Collaborator

@mukunku @giamir No, we shouldn't have a use case where we use vertical upvote only button. The vertical variant is for up and down only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants