test(visual): fix retry logic silently passing on exhausted retries

packages/stacks-classic/lib/test/visual-test-utils.ts

@@ -23,6 +23,7 @@ const scheduleVisualTest = ({
         }
 
         let retryAttempts = 3;
+        let lastError: Error | null = null;
 
         do {
             await fixture(element);
@@ -37,21 +38,22 @@ const scheduleVisualTest = ({
                 return;
             } catch (error) {
                 const e = error as Error;
-                // if the error is not a visual diff failure, retry
-                // this is to prevent flaky tests due to snapshot capturing
-                if (
-                    retryAttempts > 0 &&
-                    !e.message.includes("Visual diff failed.")
-                ) {
-                    retryAttempts--;
-                    continue;
-                } else {
+                lastError = e;
+                // if the error is a visual diff failure, fail immediately
+                if (e.message.includes("Visual diff failed.")) {
                     throw e;
                 }
+                // otherwise retry (to prevent flaky tests due to snapshot capturing)
+                retryAttempts--;
             } finally {
                 el.remove();
             }
         } while (retryAttempts > 0);
+
+        // If we exhausted all retries without success, throw the last error
+        if (lastError) {
+            throw lastError;
+        }
     });
 };