Skip to content

8.6 Support HOTKEYS #3008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mgravell wants to merge 27 commits into
base: main
Choose a base branch
from
Open

8.6 Support HOTKEYS #3008

mgravell wants to merge 27 commits into from
+1,115 −7

Conversation

@mgravell
Copy link
Collaborator

@mgravell mgravell commented Feb 7, 2026 •
edited
Loading

HOTKEYS is a new profiling API in 8.6, allowing a server-side profiling session that shows (unsurprisingly) the "hottest" keys observed during the profiling, separately by CPU and network (which can be enabled/disabled independently).

Usage is discussed in the docs as part of this PR

  • propose API shape
  • implement
  • integration tests
  • document
  • validate "count" usage
  • validate "duration" usage
  • validate slot filter on cluster
  • find out if there's any significance to the additional array level (answer: future-proofing)
  • verify RESP3

Note tests are linked to 8.6; bumping CI to use an internal 8.6 preview:

image

On files: I'm trying a new layout here; instead of making a mess throughout huge files, I've focused these changes at the "feature" scope; the API is in HotKeys.cs, with the implementation code in sub-files:

image

IMO this is much more friendly, and if there's no objections, I'll add "get the AI to move things around" to the backlog.

@mgravell mgravell marked this pull request as ready for review February 8, 2026 21:05
mgravell added 20 commits February 8, 2026 21:10
@mgravell
github link
3c3726d
@mgravell
sample ration default is 1, not zero
f41f9ff
@mgravell
- RESP3
410ad1a 
- don't expose raw arrays
- expose API-shaped ms/us accessors
- reuse shared all-slots array
@mgravell
validate/fix cluster slot filter
4fe582c
@mgravell
validate duration
217ea42
@mgravell
docs; more tests and compensation
62899ae
@mgravell
make SharedAllSlots lazy; explicitly track empty cpu/network/slots
9510dd4
@mgravell
More docs
0646f15
@mgravell
"wow"?
b392e89
@mgravell
more words
e7f564b
@mgravell
update meaning of count
bf3aa65
@mgravell
expose a bunch of values that are conditionally present
286e8c3
@mgravell
tests on the sampled/slot-filtered metrics
96a1604
@mgravell
- naming in HotKeysResult
2420039 
- prefer Nullable<T> when not-always-present
@mgravell
pre-empt typo fix
95892a6
@mgravell
Merge branch 'main' into marc/hotkeys
da24d3d
@mgravell
CI: use internal 8.6 preview build
1d8da60
@mgravell
Merge branch 'main' into marc/hotkeys
aa5ff5c
@mgravell
additional validation on conditional members
7b5252f
@mgravell
CI image update
2a3cf75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickCraver NickCraver Awaiting requested review from NickCraver

@philon-msft philon-msft Awaiting requested review from philon-msft

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mgravell