Support 8.6 idempotent streams #3006
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDMP is a new server 8.6 feature that allows at-most-once stream additions, via a small tweak to
XADDXADD ... IDMPAUTO pid * {fields}XADD ... IDMP pid iid * {fields}A pid is a producer identifier - "who sent this?"; the optional iid identifies the individual element, think "source correlation id" - if omitted, it is auto-generated from the payload. Ultimately, if you
XADDthe same pid/iid combination in IDMP mode, it does not add duplicates; instead, you get back the message-id from the last time you added it.The tests are guarded to 8.6 which means they don't run on the current CI, since no CI image is yet available. Everything looks fine locally.
XADD IDMPXINFOfieldsXCFGSETXTRIMin 8.6Design choices:
iid/pidforXADDare represented by a newreadonly struct StreamIdempotentIdwhich replaces the usualRedisValue? messageId, since IDMP is only permitted with*as the message-id; this makes the API additions unambiguous, in particular because there are no conversion operations (contrastRedisValue).XCFGSETare represented by a newclass StreamConfiguration, since it is a variadic settings API, and we don't know how many additional options may be added in the future