Skip to content

Conversation

@samuelgarcia
Copy link
Member

After playing a bit with the rust language, and trying to reimplement the peak detection algo using "locally_exclussive"
I discover that the actual impelmentation could be fasten a lot (at least 3X faster on my machine).

Also the new implementation is is more accurate for corener cases :

  • when the theshold are not teh same by channel (the comparison must be done on the ratio and not teh value)
  • when value in the sweep are higher but not peak thenself

Also I change the exclude_sweep_ms=0.1 at many place in the code this was a bad value by default it has to be half on the peak waveforms or a bit more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant