735 feature request implement sonobuoy golang framework for kaas conformance#761
Conversation
tonifinger
requested review from
cah-patrickthiem,
fraugabel,
michal-gubricky,
piobig2871 and
tsmado
michal-gubricky
left a comment
michal-gubricky
left a comment
There was a problem hiding this comment.
Looking good to me. I was able to run the example tests against the kind cluster using make commands. Just a few things that I would add/change.
There was a problem hiding this comment.
I went through the guide and could not find the ./build.sh script in this repository. If it is not included, I would suggest adjusting the 'How to Use This Plugin' section accordingly.
There was a problem hiding this comment.
This command was intended to refer to a folder in which locally built Golang bineries should be stored.
But I have currently removed this, as executing the binaries outside a Kubernetes pod does not work without additional effort.
I will remove this command from this PR.
| @@ -61,26 +60,30 @@ For test development with Sonobuoy, [KinD](https://kind.sigs.k8s.io/) is used as | |||
| sonobuoy status | |||
There was a problem hiding this comment.
I don't think we need to use the sonobuoy status command, as we are now using the --wait flag in the make dev-run command. I would say sonobuoy status and the related text above apply when the user/developer is using the make dev-run-background command now.
There was a problem hiding this comment.
That's right. I removed the sonobuoy status commands.
There was a problem hiding this comment.
This command is also mentioned in the README of this directory. Will the README be updated in this PR, or will it be part of SovereignCloudStack/docs#221?
tonifinger
force-pushed
the
735-feature-request-implement-sonobuoy-golang-framework-for-kaas-conformance
branch
from
637963b to
e965022
Compare
|
|
Which part are you referring to? |
fraugabel
left a comment
fraugabel
left a comment
There was a problem hiding this comment.
current state worked for me
Derived from the PoC, this commit presents the setup for the provision of SCS-kaas tests using sonoboy and golang. Signed-off-by: Toni Finger <toni.finger@cloudandheat.com>
Co-authored-by: Michal Gubricky <michal.gubricky@dnation.cloud> Signed-off-by: tonifinger <129007376+tonifinger@users.noreply.github.com>
This commit introduces a development mode that allows the test suite itself to create a Kubernetes cluster for testing Signed-off-by: Toni Finger <toni.finger@cloudandheat.com>
Signed-off-by: Toni Finger <toni.finger@cloudandheat.com>
Signed-off-by: Toni Finger <toni.finger@cloudandheat.com>
tonifinger
force-pushed
the
735-feature-request-implement-sonobuoy-golang-framework-for-kaas-conformance
branch
from
bffe9d8 to
6561a31
Compare
tonifinger
deleted the
735-feature-request-implement-sonobuoy-golang-framework-for-kaas-conformance
branch
3 participants
Restructure the current sonobuoy golang framework to provide a productive setup.