Updated publish workflow #665
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes Node.js version specifications and updates the npm publish workflow configuration.
Changes:
- Standardized Node.js version format from string notation (e.g., '20.x') to numeric notation (e.g., 20)
- Added Node.js 24 to the test matrix
- Removed explicit NPM_TOKEN configuration from publish steps
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/ci.yml
Outdated
| - run: npm run doc | ||
| - name: Save build | ||
| if: matrix.node-version == '20.x' | ||
| if: matrix.node-version == '20' |
There was a problem hiding this comment.
Type mismatch in comparison: matrix.node-version is now a number (20) but is being compared to a string ('20'). This condition will always evaluate to false. Remove the quotes to compare numbers: if: matrix.node-version == 20
Suggested change
| if: matrix.node-version == '20' | |
| if: matrix.node-version == 20 |
…: write is required for OIDC at the job level, not just the workflow level. Replaced JS-DevTools/npm-publish with direct npm publish commands — setup-node with registry-url configures npm to use OIDC, and direct npm publish will use that configuration.
…sure OIDC support.
….git to match the actual GitHub repository name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes applied
Removed token authentication: ${{ secrets.NPM_TOKEN }} from the publish steps.
Added OIDC permissions: id-token: write at the workflow and job levels.
Updated npm version: Added npm install -g npm@latest to ensure npm >= 11.5.1 (required for OIDC).
Switched to direct npm publish: Replaced JS-DevTools/npm-publish with direct npm publish commands so npm uses the OIDC token from setup-node.
Fixed repository URL case: Updated package.json repository URL from git+https://github.com/solidos/solid-ui.git to git+https://github.com/SolidOS/solid-ui.git to match the GitHub repository name.