update diagram decision to consider closing opened issue if no more p…

pyproject.toml

@@ -48,6 +48,7 @@ test = [
     "coverage-badge",
     "pytest",
     "pytest-cov",
+    "setuptools<82.0.0",
 ]
 docs = [
     "furo>=2025.12.19",

src/sw_metadata_bot/analysis_runtime.py

@@ -220,6 +220,11 @@ def is_previous_issue_open(previous_record: dict[str, object]) -> bool:
     if state in {"closed", "close"}:
         return False
 
+    # If the previous analysis already closed the issue, treat it as closed
+    # regardless of whether previous_issue_state was persisted.
+    if previous_record.get("action") == "closed":
+        return False
+
     issue_url = previous_record.get("issue_url") or previous_record.get(
         "previous_issue_url"
     )

src/sw_metadata_bot/publish.py

@@ -238,6 +238,7 @@ def publish_analysis(analysis_root: Path) -> None:
                 issue_client.close_issue(issue_url)
 
                 record["issue_url"] = issue_url
+                record["previous_issue_state"] = "closed"
                 record["dry_run"] = False
                 record["issue_persistence"] = "posted"
                 record.pop("simulated_issue_url", None)

tests/test_incremental.py

@@ -71,3 +71,17 @@ def test_no_findings_closes_open_issue():
     )
     assert decision.action == "close"
     assert decision.reason == "no_findings_close_open_issue"
+
+
+def test_no_findings_already_closed_issue_stops():
+    """Stop without repeat action when issue was already closed in previous analysis."""
+    decision = incremental.evaluate(
+        previous_exists=True,
+        unsubscribed=False,
+        repo_updated=True,
+        has_findings=False,
+        identical_findings=True,
+        previous_issue_open=False,
+    )
+    assert decision.action == "stop"
+    assert decision.reason == "no_findings"

tests/test_pipeline.py

@@ -8,6 +8,51 @@
 from sw_metadata_bot import analysis_runtime, commit_lookup, pipeline
 from sw_metadata_bot import publish as publish_module
 
+# ---------------------------------------------------------------------------
+# is_previous_issue_open
+# ---------------------------------------------------------------------------
+
+
+def test_is_previous_issue_open_false_when_action_closed():
+    """Return False when the previous record action is closed, regardless of issue_url."""
+    record = {
+        "action": "closed",
+        "issue_url": "https://github.com/example/repo/issues/1",
+        "issue_persistence": "posted",
+    }
+    assert analysis_runtime.is_previous_issue_open(record) is False
+
+
+def test_is_previous_issue_open_false_when_previous_issue_state_closed():
+    """Return False when previous_issue_state is explicitly closed."""
+    record = {
+        "action": "closed",
+        "issue_url": "https://github.com/example/repo/issues/1",
+        "issue_persistence": "posted",
+        "previous_issue_state": "closed",
+    }
+    assert analysis_runtime.is_previous_issue_open(record) is False
+
+
+def test_is_previous_issue_open_true_for_posted_open_issue():
+    """Return True when an issue was posted and no closing signal exists."""
+    record = {
+        "action": "created",
+        "issue_url": "https://github.com/example/repo/issues/2",
+        "issue_persistence": "posted",
+    }
+    assert analysis_runtime.is_previous_issue_open(record) is True
+
+
+def test_is_previous_issue_open_false_for_simulated_issue():
+    """Return False for simulated (dry-run) issues that were never posted."""
+    record = {
+        "action": "simulated_created",
+        "issue_url": "https://github.com/example/repo/issues/3",
+        "issue_persistence": "simulated",
+    }
+    assert analysis_runtime.is_previous_issue_open(record) is False
+
 
 def _write_config(tmp_path, **overrides):
     """Write a minimal config and return its path."""