Skip to content

Migrate GLT DistServer to GiGL.#476

Merged
kmontemayor2-sc merged 7 commits intomainfrom
kmonte/migrate-glt-dist-server
Feb 10, 2026
Merged

Migrate GLT DistServer to GiGL.#476
kmontemayor2-sc merged 7 commits intomainfrom
kmonte/migrate-glt-dist-server

Conversation

@kmontemayor2-sc
Copy link
Collaborator

Scope of work done

We need to do this as for GraphStore mode we need to initiate the sampling producers on the servers, which has been done inside the GLT dist_loader 1, but since we have our own sampling producer with ABLP logic 2, we need to call that producer.

Ultimately the DistServer is responsible for instantiating the producer 3 so we need to have our own server.

Also rename our DistSamplingProducer -> DistAblpSamplingProducer to clarify (I was getting confused as the two names are very similar otherwise).

I'll have a follow-up to migrate the storage_utils stuff to this class :)

I do have an MVP for the ablp loader with graph store - see #475

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

Copy link
Collaborator

@mkolodner-sc mkolodner-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kyle! Generally LGTM, as we are primarily just migrating code from GLT IIUC.

@kmontemayor2-sc
Copy link
Collaborator Author

/integration_test

@kmontemayor2-sc
Copy link
Collaborator Author

/e2e_test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

GiGL Automation

@ 23:47:23UTC : 🔄 Integration Test started.

@ 24:55:30UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

GiGL Automation

@ 23:47:29UTC : 🔄 E2E Test started.

@ 01:14:59UTC : ✅ Workflow completed successfully.

Copy link
Collaborator

@svij-sc svij-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamping since its been reviewed already

@kmontemayor2-sc
Copy link
Collaborator Author

FYI @svij-sc @mkolodner-sc I moved the file to graph_store/ as it's only used for graph store mode.

@kmontemayor2-sc kmontemayor2-sc marked this pull request as ready for review February 10, 2026 17:09
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue Feb 10, 2026
Merged via the queue into main with commit 81a145c Feb 10, 2026
6 checks passed
@kmontemayor2-sc kmontemayor2-sc deleted the kmonte/migrate-glt-dist-server branch February 10, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants