Improve MemCacheStoreCAS patch to properly pass serialized entries to Dalli#624
Merged
Edouard-chin merged 1 commit intoShopify:mainfrom Feb 27, 2026
Merged
Conversation
Contributor
Author
|
cc @adrianna-chang-shopify @Edouard-chin (sorry not sure who watches the repo, and you are the last few to have merged / released :) ) |
byroot
commented
Feb 27, 2026
| end | ||
| end | ||
|
|
||
| if ActiveSupport::Cache::MemCacheStore.instance_method(:deserialize_entry).arity == 1 |
Contributor
Author
There was a problem hiding this comment.
That is no longer necessary as we require Rails >= 7.0
… Dalli Instead it was relying on the fact that dalli will Marshal those, but it's much preferable to rely on the Active Support layer instead, given Dalli 4 deprecate Marshal and Dalli 5 no longer does it by default.
byroot
force-pushed
the
cas-serialization
branch
from
23dd93e to
150ae4e
Compare
Edouard-chin
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead it was relying on the fact that dalli will Marshal those, but it's much preferable to rely on the Active Support layer instead, given Dalli 4 deprecate Marshal and Dalli 5 no longer does it by default.