fix(skeleton): include line item children recursively#3753
Open
martin-pettersson wants to merge 2 commits intoShopify:mainfrom
Open
fix(skeleton): include line item children recursively#3753martin-pettersson wants to merge 2 commits intoShopify:mainfrom
martin-pettersson wants to merge 2 commits intoShopify:mainfrom
Conversation
Rename local variable shadowing line item children to include children recursively.
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
Author
|
I have signed the CLA! |
andguy95
requested changes
May 4, 2026
Collaborator
andguy95
left a comment
andguy95
left a comment
There was a problem hiding this comment.
Great catch @martin-pettersson !
Code looks good. Please do create a changeset for the skeleton template so the hydrogen cli gets this latest change on newly scaffolded projects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems to me that the
childrenvariable in the if statement shadows the returned children and thus prevents children to be included recursively.This is not tested in any way it just seemed to me that the intention is to include line item children recursively.