CLOSED - superseded by #3736#3735
Closed
itsjustriley wants to merge 4 commits into
Closed
Conversation
Fixes #3708 Cart operations were unconditionally declaring `$visitorConsent: VisitorConsent` in GraphQL mutations, causing schema validation failures on stores without the VisitorConsent type (older API versions or certain store configurations). The visitorConsent parameter is now only included when explicitly provided via `optionalParams.visitorConsent`. This restores compatibility while preserving the feature for users who need it. Changes: - Add cart-query-helpers.ts with getInContextVariables/getInContextDirective - Update 16 cart mutation files to use conditional inclusion - Add tests verifying conditional behavior Co-Authored-By: Claude Opus 4.5 (1M context) <noreply@anthropic.com>
Same root cause as the hydrogen fix - cart queries were unconditionally
declaring `$visitorConsent: VisitorConsent`, causing schema validation
failures on stores without that type.
Cart query functions now accept an optional second parameter:
`{ includeVisitorConsent?: boolean }`. The visitorConsent variable and
directive argument are only included when explicitly enabled.
Co-Authored-By: Claude Opus 4.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 (1M context) <noreply@anthropic.com>
Add a new skill documenting how to write blog posts and changelog entries for Hydrogen releases. Also update hydrogen-release-process skill to include blog posts as step 5 in the release flow. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
itsjustriley
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The branch was accidentally created with stale changes from a previous session. Please see #3736 for the actual PR.