Draft
Conversation
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
Contributor
|
So we’d need a server/proxy doing the server timings to pass it down because today it works like:
It doesn’t have to be server timings, but we need to make the tokens available client-side, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Hydrogen's analytics layer is currently tightly coupled to React via
<Analytics.Provider>. This blocks adoption by non-React frameworks and creates unnecessary dependency for what is fundamentally a pub/sub + consent + Monorail dispatch pipeline. Extracting a framework-agnostic package unlocks headless analytics for any JavaScript storefront.WHAT is this pull request doing?
Introduces
@shopify/hydrogen-analytics— a new, zero-dependency package that extracts the analytics event bus out of@shopify/hydrogeninto a standalone, framework-agnostic module.New package (
packages/hydrogen-analytics/):createAnalyticsBus) — isolated pub/sub with register/ready gating, consent-aware publish, and cleanup viadestroy()updateCart()that emits granularproduct_added_to_cart/product_removed_from_carteventswindow.Shopify.customerPrivacy) to inject headless storefront configuration before the SDK initializes_shopify_y/_shopify_scookie management (marked for removal)HOW to test your changes?
pnpm installfrom the repo rootcd packages/hydrogen-analytics && pnpm test— runs the full unit test suitepnpm buildfrom the package to verify the tsup build produces valid ESM outputtemplates/commercetemplate (if available) or create a minimal HTML page that importscreateAnalyticsBusand publishes apage_viewedevent — confirm Monorail requests fire in the Network tabChecklist