Fix breaking-change check flagging pre-existing major changesets on main#7533
Merged
Conversation
The breaking-change detection script already scopes its OCLIF manifest and Zod schema scans to files actually modified in the PR diff, but checkChangesets() was scanning every .changeset/*.md regardless. That meant a major changeset already merged to main (e.g. one staged for the next major release) would re-fail the breaking-change job on every unrelated PR. Scope checkChangesets() to changedFiles the same way as the manifest and schema scans, preserving the legacy 'scan everything' behavior when the script is invoked locally without GITHUB_BASE_REF. Adds three regression tests: - only PR-introduced major changesets are flagged - legacy local mode (no changedFiles) still scans everything - no flag when the PR doesn't touch any changeset
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
alfonso-noriega
changed the title
github-actions
Bot
added
the
no-changelog
gonzaloriestra
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The breaking-change detection job currently fails on every PR opened against
mainwhile a major-bump changeset is staged for the next major release (e.g.thin-webs-notice.md), even when the PR's own diff has nothing to do with breaking changes. See PR #7532 — it modifies a single test file and still fails the gate.WHAT is this pull request doing?
workspace/src/major-change-check.jsalready scopes its OCLIF manifest and Zod schema scans to files actually modified in the PR (viachangedFiles), butcheckChangesets()was scanning every.changeset/*.mdregardless. This change scopes it the same way:mainthat the PR doesn't touch are ignored.GITHUB_BASE_REF.Adds three regression tests: PR-introduced changeset is flagged, pre-existing one is ignored, and the local fallback still scans everything.
How to test your changes?
All 16 tests pass. To verify against a real PR, rerun the
Breaking change detectionjob on a PR whose only changes don't include a.changeset/file — the job should now logNo changeset files changed in this PR, skippingand pass.Checklist
workspace/src/, no changeset needed.