Skip to content

Immediate UI feedback for shopify app execute and shopify app bulk execute #6793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericlee878 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

Immediate UI feedback for shopify app execute and shopify app bulk execute #6793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/app/src/cli/commands/app/bulk/execute.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import AppLinkedCommand, {AppLinkedCommandOutput} from '../../../utilities/app-l
import {executeBulkOperation} from '../../../services/bulk-operations/execute-bulk-operation.js'
import {prepareExecuteContext} from '../../../utilities/execute-command-helpers.js'
import {globalFlags} from '@shopify/cli-kit/node/cli'
import {renderInfo} from '@shopify/cli-kit/node/ui'

export default class BulkExecute extends AppLinkedCommand {
static summary = 'Execute bulk operations.'
Expand All @@ -19,6 +20,10 @@ export default class BulkExecute extends AppLinkedCommand {
}

async run(): Promise<AppLinkedCommandOutput> {
renderInfo({
headline: 'Preparing bulk operation...',
})

const {flags} = await this.parse(BulkExecute)

const {query, appContextResult, store} = await prepareExecuteContext(flags)
Expand Down
5 changes: 5 additions & 0 deletions packages/app/src/cli/commands/app/execute.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import AppLinkedCommand, {AppLinkedCommandOutput} from '../../utilities/app-link
import {executeOperation} from '../../services/execute-operation.js'
import {prepareExecuteContext} from '../../utilities/execute-command-helpers.js'
import {globalFlags} from '@shopify/cli-kit/node/cli'
import {renderInfo} from '@shopify/cli-kit/node/ui'

export default class Execute extends AppLinkedCommand {
static summary = 'Execute GraphQL queries and mutations.'
Expand All @@ -18,6 +19,10 @@ export default class Execute extends AppLinkedCommand {
}

async run(): Promise<AppLinkedCommandOutput> {
renderInfo({
headline: 'Preparing GraphQL operation...',
})

const {flags} = await this.parse(Execute)

const {query, appContextResult, store} = await prepareExecuteContext(flags)
Expand Down
Loading