[Tests] Remove filesystem mocks in execute-operation.test.ts#7532
[Tests] Remove filesystem mocks in execute-operation.test.ts#7532gonzaloriestra wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
gonzaloriestra
temporarily deployed
to
breaking-change-approval
GitHub Actions
Inactive
Refactor packages/app/src/cli/services/execute-operation.test.ts to
remove global filesystem mocking. By eliminating
vi.mock('@shopify/cli-kit/node/fs'), the tests now interact with the
real filesystem within an isolated inTemporaryDirectory. Brittle
implementation-coupled assertions on writeFile call counts are
replaced with behavioral assertions that verify the resultant file
state using readFile.
Duplicate check:
Ran 'git log --grep="\[Tests\]" --oneline' and verified no previous
PR refactored this specific file to remove filesystem mocks.
gonzaloriestra
force-pushed
the
remove-fs-mock-execute-operation-test-7362924430070990755
branch
from
e6fd34a to
5846d4b
Compare
1 participant
Refactor
packages/app/src/cli/services/execute-operation.test.tsto remove global filesystem mocking. By eliminatingvi.mock('@shopify/cli-kit/node/fs'), the tests now interact with the real filesystem within an isolatedinTemporaryDirectory. Brittle implementation-coupled assertions onwriteFilecall counts are replaced with behavioral assertions that verify the resultant file state usingreadFile.PR created automatically by Jules for task 7362924430070990755 started by @gonzaloriestra