Refactor model config#109
Open
JosephMarinier wants to merge 2 commits intomainfrom
Open
Conversation
from `_check_companion_services()`, not just the first one.
- Get rid of `_strip_other_mode_fields()` by merging the 3 model classes into a single `ModelConfig` that always accepts extra `EVA_MODEL__*_PARAMS` environment variables, even if not used. - Skip validating `EVA_MODEL__*` environment variables when `EVA_MAX_RERUN_ATTEMPTS=0` (and not when `EVA_FORCE_RERUN_METRICS=True`, since it could be set while there are still conversations to rerun). That way, if you specify `EVA_MAX_RERUN_ATTEMPTS=0`, you no longer need to remove these `EVA_MODEL__*` environment variables from your `.env` file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_check_companion_services(), not just the first one._strip_other_mode_fields()by merging the 3 model classes into a singleModelConfigthat always accepts extraEVA_MODEL__*_PARAMSenvironment variables, even if not used. This removed 82 lines of code insrc/eva/models/config.py.EVA_MODEL__*environment variables whenEVA_MAX_RERUN_ATTEMPTS=0. That way, if you specifyEVA_MAX_RERUN_ATTEMPTS=0, you no longer need to remove theseEVA_MODEL__*environment variables from your.envfile. Somewhat-breaking change: we used to skip validatingEVA_MODEL__*environment variables whenEVA_FORCE_RERUN_METRICS=True, but it could be set while there are still conversations to rerun, so now you have to specifyEVA_MAX_RERUN_ATTEMPTS=0.