Skip to content

Revert "Add Kimi K2.5 INT4 single-node MI325X vLLM benchmark (TP8)"#900

Merged
cquil11 merged 1 commit intomainfrom
revert-857-claude/issue-856-20260303-0249
Mar 10, 2026
Merged

Revert "Add Kimi K2.5 INT4 single-node MI325X vLLM benchmark (TP8)"#900
cquil11 merged 1 commit intomainfrom
revert-857-claude/issue-856-20260303-0249

Conversation

@cquil11
Copy link
Collaborator

@cquil11 cquil11 commented Mar 10, 2026

Reverts #857

@github-actions
Copy link
Contributor

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

1 similar comment
@github-actions
Copy link
Contributor

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

@cquil11 cquil11 merged commit aaec16f into main Mar 10, 2026
5 checks passed
@cquil11 cquil11 deleted the revert-857-claude/issue-856-20260303-0249 branch March 10, 2026 15:22
Copy link
Contributor

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, clean revert of a benchmark config addition.

Extended reasoning...

Overview

This PR is a GitHub-generated revert of PR #857, which had added the Kimi K2.5 INT4 single-node MI325X vLLM benchmark (TP8). The changes remove: (1) the kimik2.5-int4-mi325x-vllm config block from .github/configs/amd-master.yaml, (2) the benchmark shell script benchmarks/single_node/kimik2.5_int4_mi325x.sh, and (3) the corresponding changelog entry from perf-changelog.yaml.

Security risks

None. The PR only removes benchmark configuration and a benchmark launch script. No authentication, permissions, or sensitive data handling is involved.

Level of scrutiny

Low scrutiny is appropriate. This is a mechanical, auto-generated revert that purely removes config entries and a shell script. The git log on master already shows the corresponding revert commit (7208bbc), confirming this is an intentional rollback.

Other factors

No outstanding reviewer comments exist (only automated bot messages). No bugs were found. The diff is self-contained and does not affect any shared infrastructure or production code paths — only benchmark definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant