everything-alpha: Persist more files, add arm64 support#2547
everything-alpha: Persist more files, add arm64 support#2547z-Fng merged 11 commits intoScoopInstaller:masterfrom
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdd a top-level Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Installer as Installer Script
participant Persist as $persist_dir
participant AppDir as $dir
rect rgba(135,206,235,0.5)
Installer->>Persist: Ensure `plugins` exists
Installer->>AppDir: Ensure `plugins` exists
end
rect rgba(144,238,144,0.5)
Installer->>Persist: Copy `*.csv, *.lng, *.db, *.ini, Session*.json, NO_ALPHA_INSTANCE` -> AppDir (Force)
Installer->>Persist: Copy `plugins/*` -> AppDir/plugins (Force, Recurse)
end
rect rgba(255,228,196,0.5)
Installer->>AppDir: On uninstall, ensure `plugins` exists
Installer->>AppDir: Copy `plugins/*` -> Persist/plugins (Force, Recurse)
Installer->>AppDir: Copy `*.csv, *.lng, *.db, *.ini, Session*.json, NO_ALPHA_INSTANCE` -> Persist (Force)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. everything-alpha
|
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/everything-alpha.json(3 hunks)
🔇 Additional comments (2)
bucket/everything-alpha.json (2)
23-23: Verify NO_ALPHA_INSTANCE file persistence.The PR objectives mention that users create a
NO_ALPHA_INSTANCEempty file to disable the alpha instance. However, the file patterns on lines 23 and 47 ('*.csv', '*.lng', '*.db', '*.ini', 'Session*.json') won't match this filename.Confirm whether this file should be explicitly added to the copy patterns (e.g.,
'NO_ALPHA_INSTANCE') or if it's stored in a location already covered by the plugins directory persistence.Also applies to: 47-47
17-48: Plugin directory approach looks sound.The separation of plugin persistence from session/config data is well-organized, and ensuring directories exist before operations is defensive. Once the
-Recurseflags are added, the persistence strategy should be robust.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/everything-alpha.json`:
- Around line 23-24: The current PowerShell copy commands "Get-ChildItem
\"$persist_dir\\*\" -Include '*.csv', '*.lng', '*.db', '*.ini', 'Session*.json'
| Copy-Item -Destination \"$dir\" -ErrorAction SilentlyContinue" and
"Get-ChildItem \"$persist_dir\\plugins\\*\" | Copy-Item -Destination
\"$dir\\plugins\" -ErrorAction SilentlyContinue -Force" miss the
NO_ALPHA_INSTANCE marker (no extension); update both the pre_install and
pre_uninstall copy command strings to explicitly include "NO_ALPHA_INSTANCE" (or
add a separate Copy-Item for "$persist_dir\\NO_ALPHA_INSTANCE") so the file is
persisted during install/uninstall flows.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b2b97e1f-6270-42d4-aa0d-e19d3498ce9d
📒 Files selected for processing (1)
bucket/everything-alpha.json
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with everything-alpha
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. everything-alpha
|
Fixed installed Plugin Persistence
Fixed additional file persistence (using broader pattern for
csv,db,lngandinifilesCloses [Bug]: Improve persist of everything-alpha #1520
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
New Features
Chores