Skip to content

everything-alpha: Persist more files, add arm64 support#2547

Merged
z-Fng merged 11 commits intoScoopInstaller:masterfrom
SiriosDev:everything-alpha-persist-fix
Apr 13, 2026
Merged

everything-alpha: Persist more files, add arm64 support#2547
z-Fng merged 11 commits intoScoopInstaller:masterfrom
SiriosDev:everything-alpha-persist-fix

Conversation

@SiriosDev
Copy link
Copy Markdown
Contributor

@SiriosDev SiriosDev commented Oct 31, 2025

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • New Features

    • Installer notes now explicitly show the registry import command for adding Everything to the context menu.
  • Chores

    • Improved install/uninstall persistence: plugins are explicitly marked for persistence and session files plus a NO_ALPHA_INSTANCE marker are now included in preserved files for more reliable bi-directional restore.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Oct 31, 2025

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

Add a top-level persist field ["plugins"]; change notes to a two-item array that explicitly runs reg import "$dir\\install-context.reg"; ensure plugins dirs exist in persist and install locations; broaden persisted file patterns to *.csv, *.lng, *.db, *.ini, Session*.json, and NO_ALPHA_INSTANCE; sync plugins recursively during pre-install and pre-uninstall.

Changes

Cohort / File(s) Summary
Everything-alpha manifest persistence enhancement
bucket/everything-alpha.json
Added top-level persist: ["plugins"]; notes changed to a 2-item array including reg import "$dir\\install-context.reg"; pre_install ensures $persist_dir\plugins and $dir\plugins, copies *.csv, *.lng, *.db, *.ini, Session*.json, NO_ALPHA_INSTANCE from $persist_dir$dir, and recursively copies $persist_dir\plugins\*$dir\plugins (-Force -Recurse). pre_uninstall ensures plugin dirs, recursively copies $dir\plugins\*$persist_dir\plugins, then copies the same broader globs from $dir$persist_dir (-Force).

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant Installer as Installer Script
    participant Persist as $persist_dir
    participant AppDir as $dir

    rect rgba(135,206,235,0.5)
    Installer->>Persist: Ensure `plugins` exists
    Installer->>AppDir: Ensure `plugins` exists
    end

    rect rgba(144,238,144,0.5)
    Installer->>Persist: Copy `*.csv, *.lng, *.db, *.ini, Session*.json, NO_ALPHA_INSTANCE` -> AppDir (Force)
    Installer->>Persist: Copy `plugins/*` -> AppDir/plugins (Force, Recurse)
    end

    rect rgba(255,228,196,0.5)
    Installer->>AppDir: On uninstall, ensure `plugins` exists
    Installer->>AppDir: Copy `plugins/*` -> Persist/plugins (Force, Recurse)
    Installer->>AppDir: Copy `*.csv, *.lng, *.db, *.ini, Session*.json, NO_ALPHA_INSTANCE` -> Persist (Force)
    end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 I hop and sync both near and far,

I tuck your plugins in a jar,
INIs, CSVs, each tiny file,
I guard your sessions with a smile,
A rabbit tidies every install.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions 'Persist more files' which aligns with the main changes (adding Session*.json and NO_ALPHA_INSTANCE to persist lists), but includes 'add arm64 support' which is not reflected in the actual changeset. Update the title to remove 'add arm64 support' or clarify what ARM64 support changes are included. The title should accurately reflect only the changes present in the diff.
Description check ❓ Inconclusive The description includes issue closure reference (#1520) and checklist items, but it lacks the conventional PR title format recommended in the template. While the PR description mentions using conventional title format was checked, the description itself could be clearer about what specific changes were made to the manifest.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The PR successfully addresses all coding requirements from issue #1520: persisting the plugins folder, NO_ALPHA_INSTANCE file, and Session files as indicated by the code changes.
Out of Scope Changes check ✅ Passed All changes to bucket/everything-alpha.json are directly related to the linked issue #1520, modifying persistence configuration and the reg import notes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

everything-alpha

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 42ad80a and 0be4096.

📒 Files selected for processing (1)
  • bucket/everything-alpha.json (3 hunks)
🔇 Additional comments (2)
bucket/everything-alpha.json (2)

23-23: Verify NO_ALPHA_INSTANCE file persistence.

The PR objectives mention that users create a NO_ALPHA_INSTANCE empty file to disable the alpha instance. However, the file patterns on lines 23 and 47 ('*.csv', '*.lng', '*.db', '*.ini', 'Session*.json') won't match this filename.

Confirm whether this file should be explicitly added to the copy patterns (e.g., 'NO_ALPHA_INSTANCE') or if it's stored in a location already covered by the plugins directory persistence.

Also applies to: 47-47


17-48: Plugin directory approach looks sound.

The separation of plugin persistence from session/config data is well-organized, and ensuring directories exist before operations is defensive. Once the -Recurse flags are added, the persistence strategy should be robust.

Comment thread bucket/everything-alpha.json Outdated
Comment thread bucket/everything-alpha.json Outdated
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@bucket/everything-alpha.json`:
- Around line 23-24: The current PowerShell copy commands "Get-ChildItem
\"$persist_dir\\*\" -Include '*.csv', '*.lng', '*.db', '*.ini', 'Session*.json'
| Copy-Item -Destination \"$dir\" -ErrorAction SilentlyContinue" and
"Get-ChildItem \"$persist_dir\\plugins\\*\" | Copy-Item -Destination
\"$dir\\plugins\" -ErrorAction SilentlyContinue -Force" miss the
NO_ALPHA_INSTANCE marker (no extension); update both the pre_install and
pre_uninstall copy command strings to explicitly include "NO_ALPHA_INSTANCE" (or
add a separate Copy-Item for "$persist_dir\\NO_ALPHA_INSTANCE") so the file is
persisted during install/uninstall flows.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b2b97e1f-6270-42d4-aa0d-e19d3498ce9d

📥 Commits

Reviewing files that changed from the base of the PR and between 0be4096 and be73984.

📒 Files selected for processing (1)
  • bucket/everything-alpha.json

Comment thread bucket/everything-alpha.json Outdated
@SiriosDev SiriosDev changed the title everything-alpha@1.5.0.1400a: fix persistent data everything-alpha@1.5.0.1408a: Fix Persist Apr 11, 2026
Comment thread bucket/everything-alpha.json Outdated
Comment thread bucket/everything-alpha.json Outdated
@z-Fng z-Fng changed the title everything-alpha@1.5.0.1408a: Fix Persist everything-alpha: Persist more files Apr 12, 2026
@z-Fng
Copy link
Copy Markdown
Member

z-Fng commented Apr 13, 2026

/verify

@github-actions
Copy link
Copy Markdown
Contributor

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

everything-alpha

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng z-Fng changed the title everything-alpha: Persist more files everything-alpha: Persist more files, add arm64 support Apr 13, 2026
@ScoopInstaller ScoopInstaller deleted a comment from github-actions bot Apr 13, 2026
@z-Fng
Copy link
Copy Markdown
Member

z-Fng commented Apr 13, 2026

/verify

@github-actions
Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

everything-alpha

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link
Copy Markdown
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng z-Fng merged commit 74ea11f into ScoopInstaller:master Apr 13, 2026
3 checks passed
@SiriosDev SiriosDev deleted the everything-alpha-persist-fix branch April 13, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Improve persist of everything-alpha

2 participants