Fix annotations in nested blocks#38
Closed
emortlock wants to merge 8 commits intoSassDoc:masterfrom
emortlock:fix-annotations-in-nested-blocks
Closed
Fix annotations in nested blocks#38emortlock wants to merge 8 commits intoSassDoc:masterfrom emortlock:fix-annotations-in-nested-blocks
emortlock wants to merge 8 commits intoSassDoc:masterfrom
emortlock:fix-annotations-in-nested-blocks
Conversation
# Conflicts: # index.js
pascalduez
reviewed
May 6, 2019
.travis.yml
Outdated
| - 'stable' | ||
| - 6 | ||
| - 8 | ||
| - lts/* |
Member
There was a problem hiding this comment.
Just add 6, 8, lts/*, leave the rest untouched, we will remove old node support in the next major, but until then this would be a breaking change.
Author
There was a problem hiding this comment.
Reapplied those versions, but seems to be an issue with the 4.2 pipleline job - https://travis-ci.org/SassDoc/scss-comment-parser/jobs/528927921
Can't see it being related to the changes in the PR, can't even get yarn to run using that version locally.
Worth trying 4.8 that's mentioned in the warning? Same major version so shouldn't be considered breaking?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extension of #25 to add tests around annotation parsing