Skip to content

Update Corfunc parameter definitions#3908

Open
jellybean2004 wants to merge 1 commit intomainfrom
corfunc_params
Open

Update Corfunc parameter definitions#3908
jellybean2004 wants to merge 1 commit intomainfrom
corfunc_params

Conversation

@jellybean2004
Copy link
Copy Markdown
Member

Description

This PR includes the changes suggested by @smk78 in #2110, which includes updating the definition of parameters in the Corfunc perspective.

Fixes #2110

How Has This Been Tested?

Built locally and checked the documentation.

Review Checklist:

Documentation

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)
    • Wheels installer (GH artifact) has been tested (installed and worked)

Licensing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@jellybean2004 jellybean2004 requested a review from smk78 March 25, 2026 10:43
Copy link
Copy Markdown
Contributor

@smk78 smk78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installed CI Build #5784 on W11/x64 and viewed the Corfunc documentation.
Changes look good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show the hard block volume fraction in corfunc

2 participants