Skip to content

585, 1878, 3188: Fitting report improvements#3870

Merged
krzywon merged 12 commits intomainfrom
report-improvments-3188-585
Apr 7, 2026
Merged

585, 1878, 3188: Fitting report improvements#3870
krzywon merged 12 commits intomainfrom
report-improvments-3188-585

Conversation

@krzywon
Copy link
Copy Markdown
Contributor

@krzywon krzywon commented Feb 13, 2026

Description

This overhauls the fit reports and includes a number of new features. All plots from the results panel (including DREAM plots), smearing information, and the fit Q range (in addition to the data Q range) are now shown in the report.

I've added a method to capture the batch fitting report, but too many other things need to change to make that happen here.

Fixes #585
Fixes #1878
Fixes #3188
Refs #269

How Has This Been Tested?

Tested locally from source - verified the report opens with

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)
    • Wheels installer (GH artifact) has been tested (installed and worked)

Licensing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@krzywon krzywon requested a review from smk78 February 13, 2026 17:07
@smk78
Copy link
Copy Markdown
Contributor

smk78 commented Feb 24, 2026

Tested CI build #5559 on W11/x64. Used the 2% SDS example data and fit to sphere + hayter_msa with radius polydispersity using DREAM.

Example of the new report:
report_pr3870.pdf
And then again after plotting the polydispersity, P(Q) & S(Q):
report_pr3870_2.pdf

This PR brings useful new information. Happy to approve.

Copy link
Copy Markdown
Contributor

@smk78 smk78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally, does what it says. Have not reviewed the code.

@krzywon krzywon requested a review from gonzalezma March 20, 2026 14:17
@gonzalezma
Copy link
Copy Markdown
Contributor

Code looks fine to me (just need to correct a docstring), but the part concerning the smearing info does not seem to work at 100%. I did a test selecting Instrumental Smearing = Custom Pinhole Smear: dQ/Q 1% and this info does not appear in the report.

Copy link
Copy Markdown
Contributor

@gonzalezma gonzalezma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the docstring and check why the information about Instrumental Smearing is not captured.

Comment thread src/sas/qtgui/Perspectives/Fitting/ReportPageLogic.py Outdated
@krzywon
Copy link
Copy Markdown
Contributor Author

krzywon commented Mar 23, 2026

@gonzalezma: I updated the smearing to include custom values and updated the incorrect docstring.

@krzywon
Copy link
Copy Markdown
Contributor Author

krzywon commented Mar 23, 2026

The failing unit tests are documented in #3904 and are fixed in #3906.

Copy link
Copy Markdown
Contributor

@gonzalezma gonzalezma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now. Approving.

@krzywon krzywon force-pushed the report-improvments-3188-585 branch from 6556d4f to c3941e3 Compare April 7, 2026 13:26
@krzywon krzywon merged commit 58ee1cb into main Apr 7, 2026
48 checks passed
@krzywon krzywon deleted the report-improvments-3188-585 branch April 7, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Q-range in report Fit report should include details of smearing Add DREAM results to Reports (Trac #451)

3 participants