Conversation
Owner
|
@dixon whats the status on this one? |
Collaborator
|
I am holding off merging until support for multiple framework versions is in place. |
|
Any idea when this will get fixed? I am currently running to this issue when using spatial data types with EF5 and SQL Server 2008 |
|
I used the override fix provided by Trevor from this post (http://community.miniprofiler.com/permalinks/36/the-provider-did-not-return-a-dbspatialservices-instance) and it seems to be working well for me. I hope this finds its way into the next release. I don't want to have to constantly make my own miniprofiler builds every time there is an update. |
Collaborator
|
We have moved this project to https://github.com/MiniProfiler/dotnet - would you please make your changes there? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A very simple addition to support spatial data types in SQL Server. Addresses this error:
http://community.miniprofiler.com/permalinks/36/the-provider-did-not-return-a-dbspatialservices-instance
I've tested basic reading and writing of entities using EF 5, but nothing else. And, given this was my very first usage of spatial data types, well, buyer beware!
The big hitch is it requires targeting .net 4.5. I'm not entirely sure what the best way will be to handle that, but once 4.5 is available the code changes are pretty minor.
Murray