fix(timeline): prevent emoji color bleed in read receipt display names#303
Merged
Just-Insane merged 3 commits intodevfrom Mar 16, 2026
Merged
fix(timeline): prevent emoji color bleed in read receipt display names#303Just-Insane merged 3 commits intodevfrom
Just-Insane merged 3 commits intodevfrom
Conversation
WebKit (Safari/iOS) has a rendering quirk where colorful emoji inside <b> tags can contaminate the paint color of adjacent sibling text nodes. This caused display names following a user with an emoji (e.g. '🔴 Alice') to render with the emoji's color instead of the expected text color. Apply -webkit-text-fill-color: inherit on <b> name tags and -webkit-text-fill-color: currentColor on the following <Text as="span"> elements. This explicitly resets the WebKit fill color chain at each step, preventing emoji paint properties from cascading into sibling spans. Fixes #267
Contributor
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-303-sable.raspy-dream-bb1d.workers.dev | 44e87e7 | pr-303 |
Mon, 16 Mar 2026 19:29:47 GMT |
dozro
reviewed
Mar 16, 2026
| <> | ||
| <b>{names[0]}</b> | ||
| <Text as="span" size="Inherit" priority="300"> | ||
| <b style={{ WebkitTextFillColor: 'inherit' }}>{names[0]}</b> |
Member
There was a problem hiding this comment.
is there a reason why we mix raw html <b> and react components <Text> here, i always wondered lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #267 — On Safari/iOS, colorful emoji in user display names (e.g.
🔴 Alice) bled their WebKit text fill color into adjacent text spans in the "following the conversation" indicator at the bottom of the timeline.Root cause
WebKit's implementation of
-webkit-text-fill-colorpropagates from emoji characters in a<b>tag into sibling elements under certain conditions. When a display name containing emoji was rendered as<b>🔴 Name</b>, the emoji's color fill propagated to adjacent<Text>spans like " and 2 others are following".Fix
Added
WebkitTextFillColor: 'inherit'to all<b>name tags inRoomViewFollowing.tsxto contain the WebKit fill color within the tag, andWebkitTextFillColor: 'currentColor'to the adjacent<Text as="span">elements to restore the expected text color explicitly.Applied to all 4 user-count rendering branches (1, 2, 3, and >3 users).