SBND Timing Reconstruction Refactor

[VCLanNguyen]

Description

• Timing reconstruction is refactored in this PR, affecting the decode/reconstruction workflow of CRT/PMT/XA.
• After the refactoring, the @FrameShiftModule@ runs first in the decode chain, outputs timing products to be used at PMT/XA decoder and CRTStrip reconstruction.
• Relevant PMT reconstruction modules at Reco1/Reco2 are updated.
• The timing correction applied at CAFMakeer is undone. This should ressolve this issue: Converge timing correction in CAFMaker for SBND and ICARUS #567
• Details and validation plots can before in the linked docdb.

Link(s) to docdb describing changes (optional)

https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=45982

Relevant PR links (optional)

This PR needs the XA decoder PR in sbndcode to go in first:
SBNSoftware/sbndcode#847

This PR needs to be merged together with this group of PRs:

• sbndcode: SBND Timing Reconstruction Refactor sbndcode#915
• sbncode: SBND Timing Reconstruction Refactor #637
• sbnobj: SBND Timing Reconstruction Refactor sbnobj#170
• sbnanaobj:SBND Timing Reconstruction Refactor sbnanaobj#188

Checklists

• Have you added a label? (bug/enhancement/physics etc.)
• Have you assigned at least 1 reviewer?
• Is this PR related to an open issue / project?
• Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
• Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
• Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

[VCLanNguyen]

@JosiePaton @PetrilloAtWork can you guys review for CAF?

[PetrilloAtWork]

Ops... added the comment for a different PR here.
This PR is actually fine, although I would appreciate you considering the changes I mentioned below (in particular, the bit-wise & operator is semantically wrong there, even if it works as it should).
Re-request the review of this PR after considering these, for quick approval.

[PetrilloAtWork]

My comments were addressed. Approved!