feat: enhance checkRows function to support row configuration for dynamic table rendering#21262
Draft
npapp-dev002 wants to merge 3 commits intodevelopfrom
Draft
feat: enhance checkRows function to support row configuration for dynamic table rendering#21262npapp-dev002 wants to merge 3 commits intodevelopfrom
npapp-dev002 wants to merge 3 commits intodevelopfrom
Conversation
Contributor
Merge Checks Failed |
…amic table rendering
Contributor
Merge Checks Failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version called
cy.get('cx-table th').then(...)inside the rows.forEach loop — once per row. Cypress.then()callbacks are queued asynchronously. By the time the first callback executes, the synchronousforEachhas already finished and rowIndex has reached its final value (e.g. 3 for all rows), so every assertion used the wrong row index.The fix:
cy.get('cx-table th').then(...)is called once, outside the rows loop. Inside the single.then()callback:domIndexByLabelmap is built synchronously from the real<th>elements.