refactor to use &raw mut#105
Merged
BennoLossin merged 1 commit intoRust-for-Linux:mainfrom Mar 8, 2026
Merged
Conversation
antonio-hickey
changed the title
Member
Contributor
Author
|
Yea sorry I’ve been swamped, I’ll get this finished this weekend. Have I missed this most recent release window?ThanksOn Feb 27, 2026, at 03:12, Benno Lossin ***@***.***> wrote:BennoLossin left a comment (Rust-for-Linux/pin-init#105)
We landed #102 now. So I think I'm preferring this over #49, would you mind rebasing (most of the conflicts should come from the fact that you're also carrying Gary's patch).
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Member
No worries & no rush, I also was pretty busy.
The one for 7.0, yes, but there always is a next one, so I wouldn't worry about that. |
antonio-hickey
force-pushed
the
alt-unstable-feauture
branch
from
eb3dec3 to
6e666ba
Compare
antonio-hickey
changed the title
Closed
`feature(raw_ref_op)` became stable in Rust 1.82.0 which is the current MSRV of pin-init with no default features. Earlier Rust versions will now need to enable `raw_ref_op` to continue to work with pin-init. This reduces visual complexity and improves consistency with existing reference syntax. Suggested-by: Benno Lossin <lossin@kernel.org> Link: Rust-for-Linux/linux#1148 Closes: Rust-for-Linux#99 Signed-off-by: Antonio Hickey <contact@antoniohickey.com> [ Reworded commit message - Benno ] Signed-off-by: Benno Lossin <lossin@kernel.org>
BennoLossin
force-pushed
the
alt-unstable-feauture
branch
from
6e666ba to
e277630
Compare
Member
|
@antonio-hickey I took the liberty to adjust the commit message & rebase this PR (no changes were required). Thanks a lot for working on this! I'll merge this when CI passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing all occurrences of addr_of_mut!(place) with &raw mut place.
This will allow us to reduce macro complexity, and improve consistency with existing reference syntax as &raw mut is similar to &mut making it fit more naturally with other existing code.
NOTE: A alternative version of #49, but based on #102