Added async flow in imageUpscale, alias for IUpscaleSettings as ISettings#266
Merged
Sirsho1997 merged 3 commits intomainfrom Apr 3, 2026
Merged
Added async flow in imageUpscale, alias for IUpscaleSettings as ISettings#266Sirsho1997 merged 3 commits intomainfrom
Sirsho1997 merged 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for async delivery in imageUpscale, consolidates image upscaling settings into ISettings (with a deprecated IUpscaleSettings alias), and fixes polling/type resolution so image-based tasks return IImage results when using getResponse/polling.
Changes:
- Extend
IImageUpscalewithtargetMegapixelsanddeliveryMethod, and typesettingsasISettings(with deprecatedIUpscaleSettings). - Update
_upscaleGanto support async acknowledgements (IAsyncTaskResponse) and to conditionally includeupscaleFactor/targetMegapixels. - Update polling task-type mapping so
imageUpscale,vectorize, andimageBackgroundRemovalresolve toIImage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
runware/types.py |
Moves upscale tuning fields into ISettings, adds deprecated IUpscaleSettings, and extends IImageUpscale with targetMegapixels + deliveryMethod. |
runware/base.py |
Adds async deliveryMethod handling to _upscaleGan and updates _pollResults task-type mapping for image-returning tasks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
teith
approved these changes
Apr 3, 2026
runware/base.py
Outdated
Contributor
There was a problem hiding this comment.
should be _retry_async_with_reconnect no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
IImageUpscale:targetMegapixels, optionalupscaleFactor,deliveryMethod(default"sync").ISettings: image upscale fields (enhanceDetails,realism, and existing upscale tuning fields);IImageUpscale.settingstyped asISettings.IUpscaleSettingsas a deprecated subclass ofISettings(deprecation warning on use)._upscaleGan: asyncdeliveryMethodhandling forIAsyncTaskResponse+ polling.Changed
_pollResults:imageUpscale,vectorize, andimageBackgroundRemovalresolve toIImage(fixesgetResponsereturningIVideowithout image URLs)._upscaleGan: conditionalupscaleFactor/targetMegapixels; forwarddeliveryMethod.