Skip to content

Added new params for ISettings for 3dInference#263

Merged
Sirsho1997 merged 3 commits intomainfrom
feature-3dInferenceUpdate
Apr 3, 2026
Merged

Added new params for ISettings for 3dInference#263
Sirsho1997 merged 3 commits intomainfrom
feature-3dInferenceUpdate

Conversation

@Sirsho1997
Copy link
Copy Markdown
Collaborator

@Sirsho1997 Sirsho1997 commented Mar 27, 2026

Added

  • ISettingsnow has the following params

    • imageAutoFix: Optional[bool]
    • faceLimit: Optional[int]
    • texture: Optional[bool]
    • pbr: Optional[bool]
    • textureSeed: Optional[int]
    • textureAlignment: Optional[str]
    • textureQuality: Optional[str]
    • autoSize: Optional[bool]
    • orientation: Optional[str]
    • quad: Optional[bool]
    • compress: Optional[str]
    • smartLowPoly: Optional[bool]
    • generateParts: Optional[bool]
    • exportUv: Optional[bool]
    • geometryQuality: Optional[str]
  • I3dInputs now has images: Optional[List[Union[str, File]]]

@Sirsho1997 Sirsho1997 changed the title Added new params for ISettings Added new params for ISettings for 3dInference Apr 1, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands the 3D inference request surface by adding additional 3D-specific fields to ISettings and allowing I3dInputs to accept multiple input images (images) in addition to a single image.

Changes:

  • Added multiple new optional 3D inference parameters to ISettings (e.g., imageAutoFix, pbr, geometryQuality, etc.).
  • Added images: Optional[List[Union[str, File]]] to I3dInputs.
  • Updated _process3dInputs to preprocess inputs.images via process_image.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
runware/types.py Adds new 3D inference settings fields and introduces I3dInputs.images for multi-image inputs.
runware/base.py Preprocesses I3dInputs.images before building/sending 3D inference requests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Sirsho1997 Sirsho1997 requested a review from teith April 3, 2026 14:03
@Sirsho1997 Sirsho1997 merged commit ac86f02 into main Apr 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants