Added new params for ISettings for 3dInference#263
Merged
Sirsho1997 merged 3 commits intomainfrom Apr 3, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the 3D inference request surface by adding additional 3D-specific fields to ISettings and allowing I3dInputs to accept multiple input images (images) in addition to a single image.
Changes:
- Added multiple new optional 3D inference parameters to
ISettings(e.g.,imageAutoFix,pbr,geometryQuality, etc.). - Added
images: Optional[List[Union[str, File]]]toI3dInputs. - Updated
_process3dInputsto preprocessinputs.imagesviaprocess_image.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| runware/types.py | Adds new 3D inference settings fields and introduces I3dInputs.images for multi-image inputs. |
| runware/base.py | Preprocesses I3dInputs.images before building/sending 3D inference requests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
teith
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
ISettingsnow has the following paramsimageAutoFix: Optional[bool]faceLimit: Optional[int]texture: Optional[bool]pbr: Optional[bool]textureSeed: Optional[int]textureAlignment: Optional[str]textureQuality: Optional[str]autoSize: Optional[bool]orientation: Optional[str]quad: Optional[bool]compress: Optional[str]smartLowPoly: Optional[bool]generateParts: Optional[bool]exportUv: Optional[bool]geometryQuality: Optional[str]I3dInputsnow hasimages: Optional[List[Union[str, File]]]