fix: pass SDKConfig.KeepAlive to RunwareConfig in makeClient#5
Open
kamalkalwa wants to merge 1 commit intoRunware:mainfrom
Open
fix: pass SDKConfig.KeepAlive to RunwareConfig in makeClient#5kamalkalwa wants to merge 1 commit intoRunware:mainfrom
kamalkalwa wants to merge 1 commit intoRunware:mainfrom
Conversation
makeClient() was hardcoding KeepAlive to false instead of forwarding the value from SDKConfig, making it impossible for users to enable WebSocket keep-alive through the SDK configuration. Fixes Runware#4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
makeClient()hardcodesKeepAlive: falseinstead of forwardingcfg.KeepAlive, making it impossible to enable WebSocket keep-alive throughSDKConfig.Changes
One-line fix in
sdk.go:111— replaceKeepAlive: falsewithKeepAlive: cfg.KeepAlive.Fixes #4