fix: default steps to None so Google models are not rejected#2
Open
kamalkalwa wants to merge 1 commit intoRunware:mainfrom
Open
fix: default steps to None so Google models are not rejected#2kamalkalwa wants to merge 1 commit intoRunware:mainfrom
kamalkalwa wants to merge 1 commit intoRunware:mainfrom
Conversation
Google provider models (Imagen, Nano Banana) reject requests that include a steps parameter. The hardcoded default of 20 caused steps to always be included in API requests since the optional_params filter only skips None values. Setting the default to None allows models that support steps to use their server-side defaults, while models that do not support the parameter no longer receive it. Fixes Runware#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Google provider models (Imagen, Nano Banana) return an API error when
stepsis included in the request. The hardcoded default of20meantstepswas always sent becauseoptional_paramsfiltering only skipsNonevalues.Changes
imageInference:stepsdefault20→NonephotoMaker:stepsdefault20→NoneModels that support
stepswill use their server-side defaults whenthe parameter is not explicitly provided.
Fixes #1