Skip to content

Fix config merge order to respect user config when input signals are undefined #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix config merge order to respect user config when input signals are undefined #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da5b92b
Initial plan
Copilot Nov 11, 2025
38c3a1c
fix: Ensure input signals fall back to user config values when not pr…
Copilot Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions projects/ngx-markdown-editor/src/lib/editor/markdown-editor.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,12 +214,18 @@ export class NgxMarkdownEditorComponent {
constructor() {
// Synchronization of config and inputs
effect(() => {
const mergedConfig: Required<MarkdownEditorConfig> = {
// Merge default config with user config first
const baseConfig = {
...DEFAULT_EDITOR_CONFIG,
...this.config(),
showPreview: this.showPreviewInput() ?? true,
syncScroll: this.syncScrollInput() ?? true,
showToolbar: this.showToolbarInput() ?? true,
};

// Then apply input signals, falling back to the merged config values
const mergedConfig: Required<MarkdownEditorConfig> = {
...baseConfig,
showPreview: this.showPreviewInput() ?? baseConfig.showPreview,
syncScroll: this.syncScrollInput() ?? baseConfig.syncScroll,
showToolbar: this.showToolbarInput() ?? baseConfig.showToolbar,
};

this.internalConfig.set(mergedConfig);
Expand Down