Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed_ids_ 应该是记录被移除的前沿在原始 frontiers_ 列表中的索引位置(即第几个被删的)的,但是当调用 resetFlag(iter, frontiers_) 之后,iter 已经被 erase() 更新了,新迭代器返回了下一个合法元素,此时 rmv_idx 却没有自增,这会导致后续的 rmv_idx 索引偏移,最终 removed_ids_ 的编号不正确。
` auto resetFlag = [&](list::iterator& iter, list& frontiers) {
Eigen::Vector3i idx;
for (auto cell : iter->cells_) {
edt_env_->sdf_map_->posToIndex(cell, idx);
frontier_flag_[toadr(idx)] = 0;
}
iter = frontiers.erase(iter);
};
// std::cout << "Before remove: " << frontiers_.size() << std::endl;
removed_ids_.clear();
int rmv_idx = 0;
for (auto iter = frontiers_.begin(); iter != frontiers_.end();) {
// haveOverlap(iter->box_min_, iter->box_max_, update_min, update_max)
if (haveAnyOverlap(iter->box_min_, iter->box_max_, mins, maxs) && isFrontierChanged(*iter)) {
resetFlag(iter, frontiers_);
removed_ids_.push_back(rmv_idx);
} else {
++rmv_idx;
++iter;
}
}`