Adjust working ranges of forester, woodcutter and stonemason (3 Addons)#1941
Conversation
Flamefire
left a comment
There was a problem hiding this comment.
Thanks for the PR, looks good, just minor nits which you can apply from the UI here.
I'm thinking about making the description more explicit to avoid just repeating the name, i.e. change "Adjust the stonemason's mining range" to something like "Increase the radius in which the stonemason searches for stone" or "(possible) work area", but that doesn't sound much easier so I guess the "xxx range" is enough to understand the effect and we can keep that, unless you have an idea.
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
MichalLabuda
left a comment
There was a problem hiding this comment.
I've committed the suggestions regarding the const and good catch with the stonemason's 100% range - thanks.
I've also modified the descriptions according to your suggestion.
I added the actual work names to the addon names for clarity.
Co-authored-by: Michał Łabuda <michal_labuda@tlen.pl>
|
I'm fine with the current short addon names like "Adjust xxx's range", clear for those who know and if in doubt the tooltip provides a longer variant. I think this makes the addon list easier to read. You need to run clang-format, e.g. via |
Summary
This PR adds three gameplay addons that allow players to customize the working radius of forester, woodcutter, and stonemason.
The default gameplay behavior remains unchanged because all three addons default to the original radii.
These addons introduce selectable radius presets expressed in percentages that increase the worker’s effective reach, making it possible to interact with resources that were previously just out of range on certain maps or simply for fun. Each addon provides several percentage‑based increments, with the default option matching the original game values.
Forester and Woodcutter share identical radius presets:
Stonemason uses slightly different values:
Motivation
On some maps, it can be frustrating when a worker cannot reach a single tree or a lone granite deposit that is only slightly outside the default radius.
For personal gameplay, I previously increased these radii locally. This PR formalizes that idea by implementing it as proper optional addons so that all players can benefit from the feature without altering the default gameplay balance.
Implementation details
012 MichalLabudaAddonId::FORESTER_REACH_RADIUS = 0x01200000AddonId::WOODCUTTER_REACH_RADIUS = 0x01200001AddonId::STONEMASON_REACH_RADIUS = 0x01200002AddonForesterReachRadius.hAddonWoodcutterReachRadius.hAddonStonemasonReachRadius.hnofFarmhand::GetWorkRadius()was updated to use the selected addon values instead of hardcoded constants.