Skip to content

Fix chat lobby persistence and identity save issues#264

Open
jolavillette wants to merge 1 commit intoRetroShare:masterfrom
jolavillette:fix-chat-lobby-persistence
Open

Fix chat lobby persistence and identity save issues#264
jolavillette wants to merge 1 commit intoRetroShare:masterfrom
jolavillette:fix-chat-lobby-persistence

Conversation

@jolavillette
Copy link
Contributor

@jolavillette jolavillette commented Feb 14, 2026

Fix chat lobby persistence and identity save issues

This PR addresses a critical issue where private chat rooms and identity settings were not correctly persisted after restarting RetroShare

Changes

  • Private Invitations: Added [setLobbyAutoSubscribe()] and [triggerConfigSave()] to [acceptLobbyInvite()]. This ensures private rooms are remembered and the UI can automatically reopen the tab on the next startup.
    • Note: These calls are placed outside the mDistributedChatMtx lock to avoid recursive deadlocks.
  • Room Creation: Added [setLobbyAutoSubscribe()] to [createChatLobby()] for consistent persistence of user-created rooms.
  • Identity Updates: Added [triggerConfigSave()] to [setIdentityForChatLobby()] so that changing your nickname/identity in a specific room is immediately saved to disk.

These modifications ensure that the AUTO_SUBSCRIBE flag is correctly set and flushed to chat.cfg, preventing the loss of private chat rooms upon application restart on macOS.

@jolavillette jolavillette force-pushed the fix-chat-lobby-persistence branch 2 times, most recently from 3754213 to c2106f8 Compare February 18, 2026 22:03
@jolavillette jolavillette force-pushed the fix-chat-lobby-persistence branch from c2106f8 to 5d0950e Compare February 24, 2026 14:02
@jolavillette jolavillette changed the title Fix chat lobby persistence issues on macOS Fix chat lobby persistence issues Mar 6, 2026
@jolavillette jolavillette force-pushed the fix-chat-lobby-persistence branch from 5d0950e to 5daafd7 Compare March 6, 2026 09:18
@jolavillette jolavillette changed the title Fix chat lobby persistence issues Fix chat lobby persistence and identity save issues Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant