Skip to content

RU-T47 Trying to fix ios build#223

Merged
ucswift merged 1 commit intomasterfrom
develop
Feb 19, 2026
Merged

RU-T47 Trying to fix ios build#223
ucswift merged 1 commit intomasterfrom
develop

Conversation

@ucswift
Copy link
Member

@ucswift ucswift commented Feb 19, 2026

Summary by CodeRabbit

  • Chores

    • Updated Expo and related package versions (expo, expo-router, expo-constants, expo-image, jest-expo) to latest compatible releases
    • Updated project configuration with additional exclusions for expo doctor checks
  • Refactor

    • Consolidated package imports to use unscoped module names for better compatibility

@coderabbitai
Copy link

coderabbitai bot commented Feb 19, 2026

📝 Walkthrough

Walkthrough

This pull request migrates the codebase from the scoped @expo/config-plugins package to the unscoped expo/config-plugins package. The import paths are updated across multiple plugin files, and package.json is updated to remove the old dependency, add resolutions for @expo/metro-config, bump several package versions, and extend expo doctor exclusions.

Changes

Cohort / File(s) Summary
Plugin Import Migration
customManifest.plugin.js, plugins/withForegroundNotifications.js, plugins/withInCallAudioModule.js, plugins/withMediaButtonModule.js, plugins/withNotificationSounds.js
Updated require statements from @expo/config-plugins to expo/config-plugins across all plugin files.
Dependency and Configuration Updates
package.json
Removed @expo/config-plugins dependency; bumped expo (~53.0.27), expo-constants (~17.1.8), expo-image (~2.4.1), expo-router (~5.1.11), and jest-expo (~53.0.14); added @expo/metro-config resolution (~0.20.18); extended expo doctor exclusions to include react-native-callkeep and expo-av.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 From scoped to bare, the packages now dance,
Config-plugins freed from the @ symbol's trance,
Dependencies bumped with careful precision,
Metro mettle reinforced, the plugin's decision!
Notifications sound sweeter in exile's embrace,
A cleaner build path, a modernized space! 🌟

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is vague and non-descriptive, using only 'Trying to fix ios build' without explaining the actual changes made (dependency migration, version updates, and configuration additions). Replace with a more specific title that describes the primary change, such as 'Migrate @expo/config-plugins to expo/config-plugins and update dependencies' or 'Update Expo packages and remove deprecated config-plugins dependency'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
package.json (1)

56-178: Optional: plugin file names violate the lowercase-hyphenated naming convention.

All five plugin files — customManifest.plugin.js, withNotificationSounds.js, withInCallAudioModule.js, withForegroundNotifications.js, withMediaButtonModule.js — use camelCase rather than lowercase-hyphenated names. As per coding guidelines, directory and file names should be lowercase and hyphenated (e.g., custom-manifest.plugin.js, with-notification-sounds.js). These are pre-existing violations unrelated to the current change, but worth addressing in a follow-up.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@package.json` around lines 56 - 178, The plugin filenames violate the
lowercase-hyphenated convention; rename customManifest.plugin.js →
custom-manifest.plugin.js, withNotificationSounds.js →
with-notification-sounds.js, withInCallAudioModule.js →
with-in-call-audio-module.js, withForegroundNotifications.js →
with-foreground-notifications.js, and withMediaButtonModule.js →
with-media-button-module.js, then update every reference/import/require that
mentions those module names (search for symbols like customManifest.plugin,
withNotificationSounds, withInCallAudioModule, withForegroundNotifications,
withMediaButtonModule and replace with the new hyphenated filenames) so the
codebase and any plugin registrations point to the new filenames.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@package.json`:
- Around line 56-178: The plugin filenames violate the lowercase-hyphenated
convention; rename customManifest.plugin.js → custom-manifest.plugin.js,
withNotificationSounds.js → with-notification-sounds.js,
withInCallAudioModule.js → with-in-call-audio-module.js,
withForegroundNotifications.js → with-foreground-notifications.js, and
withMediaButtonModule.js → with-media-button-module.js, then update every
reference/import/require that mentions those module names (search for symbols
like customManifest.plugin, withNotificationSounds, withInCallAudioModule,
withForegroundNotifications, withMediaButtonModule and replace with the new
hyphenated filenames) so the codebase and any plugin registrations point to the
new filenames.

@ucswift
Copy link
Member Author

ucswift commented Feb 19, 2026

Approve

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved.

@ucswift ucswift merged commit 2691ffa into master Feb 19, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments