Use f-strings

[DimitriPapadopoulos]

Fixes a few cases not detected by ruff.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the codebase by adopting f-strings for string formatting across various files. This change enhances code readability and maintains consistency with modern Python practices, specifically targeting areas where existing linters might have missed opportunities for improvement. The update streamlines string construction, making the code cleaner and easier to understand.

Highlights

• Code Modernization: Replaced several instances of older string formatting methods (like .format() and string concatenation) with f-strings for improved readability and conciseness.
• Linter Compliance: Addressed specific cases of string formatting that were not detected by the ruff linter, ensuring more consistent code style.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• neurodocker/cli/generate.py
  • Replaced .format() with an f-string in an assertion message.
• neurodocker/reproenv/renderers.py
  • Converted string concatenation to an f-string for the 'FROM' instruction.
  • Converted string concatenation to an f-string for the 'WORKDIR' instruction.
• neurodocker/reproenv/tests/utils.py
  • Replaced string concatenation with an f-string for generating a Docker image tag.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request modernizes string formatting by replacing older methods with f-strings, which improves code readability and adheres to modern Python best practices. However, a security audit revealed that the from_ and workdir methods in DockerRenderer are vulnerable to Dockerfile injection. This vulnerability stems from a lack of validation for input parameters (base_image and path) to prevent newline characters, posing a critical risk if the tool is used in multi-tenant or web service environments. Similar injection points might exist in other parts of the codebase, such as SingularityRenderer.

[DimitriPapadopoulos]

The security concerns do not seem valid, as neurodocker is not designed for multi-tenant or web service environments. In any case, they are not specific to this PR.