Skip to content

Get rid of setup.cfg#703

Open
DimitriPapadopoulos wants to merge 1 commit intoReproNim:masterfrom
DimitriPapadopoulos:setup.cfg
Open

Get rid of setup.cfg#703
DimitriPapadopoulos wants to merge 1 commit intoReproNim:masterfrom
DimitriPapadopoulos:setup.cfg

Conversation

@DimitriPapadopoulos
Copy link

Then sdist doesn't change when uncommenting the comments in this file. It seems useless as it is.

Then sdist doesn't change when uncommenting the comments in this file.
It seems useless as it is.
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request activates the package_data configuration within setup.cfg. This change is crucial for ensuring that all necessary non-code assets, such as configuration templates and schema definitions, are properly bundled with the neurodocker package, thereby improving the completeness and functionality of the distributed software.

Highlights

  • Package Data Configuration: The [options.package_data] section in setup.cfg has been uncommented, ensuring that specific data files (YAML templates, JSON schemas, and a shell script) are correctly included in the neurodocker package distribution.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • setup.cfg
    • Activated the [options.package_data] section to include necessary data files.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request title "Get rid of setup.cfg" and its description "Then sdist doesn't change when uncommenting the comments in this file. It seems useless as it is." appear to contradict the actual code change. The change involves uncommenting the [options.package_data] section in setup.cfg, which enables the inclusion of specified files in the package distribution. This action is the opposite of "getting rid of" the configuration and suggests that the section is indeed useful, contrary to the description. Please clarify the intended outcome of this pull request.

@DimitriPapadopoulos
Copy link
Author

Pushed a new commit, as the initial one was a leftover from my sidst tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant