Conversation
… improvements 📝 Summary: This commit addresses three user-reported issues in the PH Fare Calculator app: 1. Map picker search field now shows location suggestions 2. All location input fields display loading indicators during search 3. Transport modes default to disabled with new selection modal and quick toggle 🔧 Changes: 🗺️ Map Picker Location Suggestions: - Replaced placeholder TextField with Autocomplete<Location> widget - Integrated GeocodingService for location search - Added selection logic to move map camera to chosen location ⏳ Loading Indicators: - Added ValueNotifier<bool> pattern for tracking search state - Display 16px CircularProgressIndicator in input suffix while fetching - Applied to both main screen (origin/destination) and map picker search 🚌 Transport Mode Improvements: - Changed default for all transport modes to disabled for new users - Added hasSetTransportModePreferences() to distinguish new vs existing users - Created TransportModeSelectionModal with Material 3 bottom sheet design - Modal shows modes grouped by category (Road, Rail, Water) - Added quick-access "Modes" button in TravelOptionsBar with badge count - Modal appears when calculating fare with no modes enabled 🧪 Tests: - Updated MockSettingsService and FakeSettingsService with new interface - Fixed flaky test finder in main_screen_test.dart - All 289 tests pass
- Add passenger state management when setting discount type - Fix location search loading indicator timing with post-frame callback - Load saved transport mode preferences on modal initialization - Clean up injection.config.dart formatting
…de UX improvements - Set default transport modes to Jeepney/Bus/Taxi only - Add word-wrap for origin/destination input fields (2-line limit) - Implement fare results persistence on route swap - Add real address display in map picker with debounce - Introduce Lowest Overall sort option for fare comparison - Fix storage bar accuracy in region management - Replace brackets with transport mode type chips - Improve fare result display with base name + chip formatting - Fix input field alignment (swap button and route indicator) - Correct per-person price calculation logic - Bump version to 2.2.0+4 - Update GitHub workflow for release notes generation
MasuRii
added a commit
that referenced
this pull request
Mar 16, 2026
…gestions-and-transport-mode-ux feat: implement location suggestions and comprehensive transport mode UX improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Summary
This PR implements location suggestions and comprehensive transport mode UX improvements for the PH Fare Calculator app. Users can now search for locations with autocomplete suggestions, see real-time loading indicators during searches, and enjoy a completely redesigned transport mode selection experience with Material 3 design. The feature also includes fare result persistence on route swaps, per-person price calculations, and numerous UI/UX refinements across the entire application.
🚀 New Features
🗺️ Location Suggestions with Autocomplete
🚌 Transport Mode Selection Modal (Material 3)
💰 Fare Calculation Improvements
🐛 Bug Fixes
🎨 Improvements
🎯 User Experience Enhancements
🏗️ Code Architecture
📝 Version
✅ Testing
📁 Files Changed
Core Models
lib/src/models/map_region.dartlib/src/models/transport_mode.dartControllers & Services
lib/src/presentation/controllers/main_screen_controller.dartlib/src/services/fare_comparison_service.dartlib/src/services/settings_service.dartScreens
lib/src/presentation/screens/main_screen.dartlib/src/presentation/screens/map_picker_screen.dartlib/src/presentation/screens/settings_screen.dartWidgets
lib/src/presentation/widgets/fare_result_card.dartlib/src/presentation/widgets/main_screen/fare_results_list.dartlib/src/presentation/widgets/main_screen/location_input_section.dartlib/src/presentation/widgets/main_screen/transport_mode_selection_modal.dartlib/src/presentation/widgets/main_screen/travel_options_bar.dartInfrastructure
.github/workflows/release-apk.ymllib/src/core/di/injection.config.dartpubspec.yamlTests
test/helpers/mocks.darttest/models/map_region_test.darttest/screens/main_screen_test.darttest/screens/onboarding_localization_test.darttest/screens/region_download_screen_test.dartTotal Changes: 21 files modified, 1,766 insertions(+), 269 deletions(-)
📊 Commits Included
This PR consolidates 3 commits from the feature branch:
Please review and merge after CI passes! 🚀