You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Do all paramaters, variables, models, etc. have a description?
Use absolute paths to classes! -> BESMod.Fluid.HeatExchangers.Radiator - Avoid: HeatExchangers.Radiator
If all CI stages pass and you have addressed possible naming violations, please consider the following:
Use "group" and "tab" annotations to achieve a good visualization window.
Use units consistently.
Instantiate the replaceable medium package as:
replaceable package Medium = Modelica.Media.Interfaces.PartialMedium "Medium model";
instead of using a full media model like BESMod.Media.Water directly.
Never using absolute paths to files (e.g., C: or D:). Replace them with modelica://BESMod/....
Ensure your documentation is helpful and concise.
Make sure icons are clear. Please avoid using images!
Stick to 80 characters per line, as long as it makes sense.
Once you have addressed these points, you can assign a reviewer.
Although this process may seem tedious, ensuring CI passes allows the reviewer to focus
their time on the actual modeling rather than syntax and unintended breakages caused by your changes.
If you have any questions or issues, please tag a library developer.
Once again, thank you for your valuable contribution!
FelixStege
changed the title
Add switch block
Include external control interface for heating rod
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #132