Add container and tuple optimization helpers #3590
Open
+64
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenpercent
requested review from
Snektron,
ThomasNing,
afagaj,
andriy-ca,
aosewski,
asleepzzz,
bartekxk,
carlushuang,
cgmillette,
coderfeli,
geyyer,
illsilin,
poyenc,
qianfengz,
shumway,
vidyasagar-amd and
vpietila-amd
as code owners
This was referenced Jan 16, 2026
tenpercent
force-pushed
the
mpodkory/generate-tuple-optimizations
branch
from
59f0c32 to
5190578
Compare
tenpercent
force-pushed
the
mpodkory/transform-tensor-descriptor-optimization
branch
from
885b80f to
0791bad
Compare
tenpercent
force-pushed
the
mpodkory/generate-tuple-optimizations
branch
from
5190578 to
887bdf2
Compare
1 task
tenpercent
force-pushed
the
mpodkory/transform-tensor-descriptor-optimization
branch
from
0791bad to
b26ed88
Compare
Add make_uniform_tuple<N>(value) helper to replace common pattern:
generate_tuple([&](auto) { return value; }, Number<N>{})
This avoids unique lambda instantiations when creating tuples with
repeated values. Applied to device_grouped_conv_fwd_multiple_abd.
Replace O(N) recursive container_reduce with O(1) fold expression
for computing products of container elements. This reduces template
instantiation depth from 26 to 23 levels.
- Add container_product() using unpack + fold expression
- Migrate 10 call sites from container_reduce(x, multiplies{}, 1)
Lambdas create unique types per call site, causing duplicate template instantiations. Named functors are shared across call sites. Results: - container_concat: 186 → 93 instantiations (50% reduction) - Wall-clock: 518ms → 309ms (40% reduction)
tenpercent
force-pushed
the
mpodkory/transform-tensor-descriptor-optimization
branch
from
b26ed88 to
00849ac
Compare
tenpercent
force-pushed
the
mpodkory/generate-tuple-optimizations
branch
from
887bdf2 to
02e42dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
container_concatmake_uniform_tuplehelper for repeated value patternscontainer_concatinstantiations from 186 to 93 (50% reduction)Test Plan
PR Stack
__make_integer_seqTracking issue: #3575