Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4594 +/- ##
========================================
Coverage 92.20% 92.20%
========================================
Files 567 567
Lines 27880 27880
========================================
Hits 25706 25706
Misses 2174 2174
🚀 New features to boost your workflow:
|
Collaborator
|
Do we want to consolidate changes from my draft pr #4589? |
Collaborator
Author
It shouldn't be changed to a throw. It should only throw if its collapsing two non-contiguous dimensions. |
kahmed10
approved these changes
Feb 10, 2026
Collaborator
kahmed10
left a comment
There was a problem hiding this comment.
LGTM, don't forget to mention this in the changelog
CharlieL7
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #4590.
Technical Details
Also added some additional unit tests.
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable