Skip to content

Conversation

@mrmundt
Copy link
Contributor

@mrmundt mrmundt commented Jan 21, 2026

Fixes NA

Summary/Motivation:

Gurobi released a version that actually works on 3.14 today, hooray! However, two of our gurobi_minlp tests are too strict about the expected phrasing of the error. So this loosens that / allows support for multiple Python versions.

Changes proposed in this PR:

  • Change error message regex on gurobi_minlp tests

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@mrmundt mrmundt requested review from blnicho and emma58 January 21, 2026 18:52
@boxblox
Copy link

boxblox commented Jan 21, 2026

thanks @mrmundt these fails started popping up over #3683. will watch this PR and merge in changes on success.

@mrmundt
Copy link
Contributor Author

mrmundt commented Jan 21, 2026

@boxblox - Sounds good! (I had grand plans to do real Pyomo work today... But noooo, gurobi!)

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.43%. Comparing base (312512c) to head (f171072).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3822   +/-   ##
=======================================
  Coverage   89.43%   89.43%           
=======================================
  Files         905      905           
  Lines      105444   105444           
=======================================
+ Hits        94301    94302    +1     
+ Misses      11143    11142    -1     
Flag Coverage Δ
builders 29.13% <ø> (+<0.01%) ⬆️
default 86.05% <ø> (?)
expensive 35.76% <ø> (?)
linux 86.74% <ø> (-2.46%) ⬇️
linux_other 86.74% <ø> (+0.02%) ⬆️
osx 82.89% <ø> (+<0.01%) ⬆️
win 84.96% <ø> (+<0.01%) ⬆️
win_other 84.96% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mrmundt mrmundt merged commit e4c9aa8 into Pyomo:main Jan 21, 2026
64 of 65 checks passed
@mrmundt mrmundt deleted the 314-gurobi branch January 21, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants