Skip to content

Conversation

@eminyouskn
Copy link
Contributor

Fixes # .

Summary/Motivation:

This PR updates the iteration count handling for KNITRO. Since the iteration count is not meaningful for MIP problems, the solver now returns None in those cases.

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.45%. Comparing base (4d67fa6) to head (60fa6cb).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3802   +/-   ##
=======================================
  Coverage   89.45%   89.45%           
=======================================
  Files         905      905           
  Lines      105467   105485   +18     
=======================================
+ Hits        94341    94364   +23     
+ Misses      11126    11121    -5     
Flag Coverage Δ
builders 29.13% <30.00%> (-0.01%) ⬇️
default 86.07% <100.00%> (?)
expensive 35.76% <30.00%> (?)
linux 86.76% <30.00%> (-2.46%) ⬇️
linux_other 86.76% <30.00%> (-0.02%) ⬇️
osx 82.91% <30.00%> (-0.01%) ⬇️
win 84.99% <30.00%> (-0.01%) ⬇️
win_other 84.99% <30.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blnicho blnicho requested review from jsiirola and mrmundt January 13, 2026 19:54
@eminyouskn eminyouskn changed the title [KNITRO] Remove iteration count for MIP [KNITRO] Separate Extra Information by MIP Relevance Jan 23, 2026
@eminyouskn
Copy link
Contributor Author

@mrmundt I just update this PR with what we would like to report as extra info in both cases.

Copy link
Contributor

@mrmundt mrmundt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thank you! 🥇

@mrmundt mrmundt merged commit b404bca into Pyomo:main Jan 23, 2026
35 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer Approved to Done in Pyomo 6.10 Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants